On Thu, Nov 23, 2023 at 9:50 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Wed, Nov 22, 2023 at 02:27:09PM +0200, Amir Goldstein wrote: > > All the callers of vfs_iter_write() call file_start_write() just before > > calling vfs_iter_write() except for target_core_file's fd_do_rw(). > > Can you add a patch to first add it to fd_do_rw? While this crates a > bit of churn, it has two benefits: > > - it gives us an easily backportable fix > - it makes this patch a transformation that doesn't change behavior. > > Please also cc the scsi and target lists. It probably makes sense to > even expedite it and send it for 6.7-rc inclusion separately. > be a 6.7 candidate Good idea. will do! Thanks for the review! Amir.
