> static ssize_t do_iter_read(struct file *file, struct iov_iter *iter, > - loff_t *pos, rwf_t flags) > + loff_t *pos, rwf_t flags) > +{ > + if (file->f_op->read_iter) > + return do_iter_readv_writev(file, iter, pos, READ, flags); > + else > + return do_loop_readv_writev(file, iter, pos, READ, flags); > +} That else doesn't serve a purpose here. I would just remove it. Easier on the eye too.