Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Tue, Nov 21, 2023 at 12:35:19AM +0530, Ritesh Harjani (IBM) wrote: >> Commit "filemap: update ki_pos in generic_perform_write", made updating >> of ki_pos into common code in generic_perform_write() function. >> This also causes generic/091 to fail. >> >> Fixes: 182c25e9c157 ("filemap: update ki_pos in generic_perform_write") > > Looks like this really was an in-flight collision with: > fb5de4358e1a ("ext2: Move direct-io to use iomap"). How did we manage > to not notice the failure for months, though? Yes, it was due to in-flight collision. I found it during this conversion and also noticed that generic/091 fails on upstream kernel. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! -ritesh