On Tue, Nov 21, 2023 at 12:35:20AM +0530, Ritesh Harjani (IBM) wrote: > +static void ext2_file_readahead(struct readahead_control *rac) > +{ > + return iomap_readahead(rac, &ext2_iomap_ops); We generally prefer to omit the 'return' when the function returns void (it's a GCC extension to not warn about it, so not actually a bug) This all looks marvellously simple. Good job!