On Fri, Nov 17, 2023 at 09:58:23PM +0000, Matthew Wilcox (Oracle) wrote: > It is hard to find where mapping->private_lock, mapping->private_list and > mapping->private_data are used, due to private_XXX being a relatively > common name for variables and structure members in the kernel. To fit > with other members of struct address_space, rename them all to have an > i_ prefix. Tested with an allmodconfig build. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > --- Given that there's plenty of other things with i_ in there I think this is a reasonable naming scheme. I agree with Darrick that maybe a_ would be better, but we'd have to change everything in there and that's a bit trickier. Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> Thanks, Josef
