On Mon, Nov 20, 2023 at 5:48 PM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > OOPS, missed fsnotify_put_mark(mark); > > better add a goto target out_put_mark as this is the second case now. > > I want to point out that going forward we should be able to make use of > scoped cleanup macros. Please see include/linux/cleanup.h. I think we > should start making liberal use of this. I know that Peter Ziljstra is > already doing so for kernel/sched/. Yeh, I like them, but not sure if I would use them in this case. Thanks, Amir.