Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Anish Moorthy <amoorthy@xxxxxxxxxx>
Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
From: Mark Brown <broonie@xxxxxxxxxx>
Date: Mon, 20 Nov 2023 14:09:17 +0000
Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Oliver Upton <oliver.upton@xxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Anup Patel <anup@xxxxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, kvm-riscv@xxxxxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Xiaoyao Li <xiaoyao.li@xxxxxxxxx>, Xu Yilun <yilun.xu@xxxxxxxxx>, Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>, Fuad Tabba <tabba@xxxxxxxxxx>, Jarkko Sakkinen <jarkko@xxxxxxxxxx>, David Matlack <dmatlack@xxxxxxxxxx>, Yu Zhang <yu.c.zhang@xxxxxxxxxxxxxxx>, Isaku Yamahata <isaku.yamahata@xxxxxxxxx>, Mickaël Salaün <mic@xxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Vishal Annapurve <vannapurve@xxxxxxxxxx>, Ackerley Tng <ackerleytng@xxxxxxxxxx>, Maciej Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Quentin Perret <qperret@xxxxxxxxxx>, Michael Roth <michael.roth@xxxxxxx>, Wang <wei.w.wang@xxxxxxxxx>, Liam Merwick <liam.merwick@xxxxxxxxxx>, Isaku Yamahata <isaku.yamahata@xxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
In-reply-to: <CAF7b7mpmuYLTY6OQfRRoOryfO-2e1ZumQ6SCQDHHPD5XFyhFTQ@mail.gmail.com>

On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote:
> Applying [1] and [2] reveals that this also breaks non-x86 builds- the
> MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef
> __x86_64__, while the usages introduced here aren't.
> 
> Should
> 
> On Sun, Nov 5, 2023 at 8:35 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> >
> > +       test_invalid_memory_region_flags();
> 
> be #ifdef'd, perhaps? I'm not quite sure what the intent is.

This has been broken in -next for a week now, do we have any progress
on a fix or should we just revert the patch?

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
  - From: Paolo Bonzini

References:
- [PATCH v14 00/34] KVM: guest_memfd() and per-page attributes
  - From: Paolo Bonzini
- [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
  - From: Paolo Bonzini
- Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
  - From: Anish Moorthy

Prev by Date: Re: add and use a per-mapping stable writes flag v2
Next by Date: Re: [PATCH] coda: change locking order in coda_file_write_iter()
Previous by thread: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
Next by thread: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]