On Tue, Jul 28, 2009 at 09:41:34PM +0200, Jiri Slaby wrote: > To avoid userspace build failures such as: > .../linux/uio.h:37: error: expected ???=???, ???,???, ???;???, ???asm??? or ???__attribute__??? before ???iov_length??? > .../linux/uio.h:47: error: expected declaration specifiers or ???...??? before ???size_t??? > move uio functions inside a __KERNEL__ block. > > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx> > --- > include/linux/uio.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/uio.h b/include/linux/uio.h > index b7fe138..693c149 100644 > --- a/include/linux/uio.h > +++ b/include/linux/uio.h > @@ -35,6 +35,7 @@ struct kvec { > #define UIO_FASTIOV 8 > #define UIO_MAXIOV 1024 > > +#ifdef __KERNEL__ > /* > * Total number of bytes covered by an iovec. > * > @@ -53,5 +54,6 @@ static inline size_t iov_length(const struct iovec *iov, unsigned long nr_segs) > } > > unsigned long iov_shorten(struct iovec *iov, unsigned long nr_segs, size_t to); > +#endif > > #endif Can we get this fixed up so we have a single #ifdef __KERNEL__ block? It would be prettier, and nothing the in non-kernel part would rely on the kernel part so you can put the kernel part in the bottom of the file. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html