Hello again, just in case you (or perhaps somebody else) have a minute to assist me.. On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote: > BTW, the patch has several bugs. fat_get_label_entry() doesn't check > IS_FREE(), is it right? Not 100% sure if it's needed in a consistent fs, but I guess it shouldn't do any harm, so I added it. > fat_create_label_entry() doesn't initialize all > timestamp in the case of msdos. Corrected. > spin_lock() usage is wrong. >From the code, I'm not totally sure then what inode_hash_lock is supposed to protect in fat_write_inode. Probably it should prevent that the dir entry of an inode is being moved around to another i_pos while it's being changed? But in the pre-patch version of fat_write_inode, shouldn't then mark_buffer_dirty(bh) be called when the lock is still held? Sorry for the newbie-questions, thanks for any help. Jörg -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
