Re: [PATCH 12/22] Make retain_dentry() neutral with respect to refcounting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 12/22] Make retain_dentry() neutral with respect to refcounting
From: Christian Brauner <brauner@xxxxxxxxxx>
Date: Thu, 9 Nov 2023 16:22:49 +0100
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20231109062056.3181775-12-viro@zeniv.linux.org.uk>

On Thu, Nov 09, 2023 at 06:20:46AM +0000, Al Viro wrote:
> retain_dentry() used to decrement refcount if and only if it returned
> true.  Lift those decrements into the callers.
> 
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>

References:
- [RFC][PATCHSET v2] simplifying fast_dput(), dentry_kill() et.al.
  - From: Al Viro
- [PATCH 01/22] struct dentry: get rid of randomize_layout idiocy
  - From: Al Viro
- [PATCH 12/22] Make retain_dentry() neutral with respect to refcounting
  - From: Al Viro

Prev by Date: Re: [PATCH 11/22] __dput_to_list(): do decrement of refcount in the callers
Next by Date: Re: [PATCH 12/21] fs: xfs: Introduce FORCEALIGN inode flag
Previous by thread: [PATCH 12/22] Make retain_dentry() neutral with respect to refcounting
Next by thread: [PATCH 14/22] dentry_kill(): don't bother with retain_dentry() on slow path
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux