Hi,
On 11/7/2023 16:28, Luck, Tony wrote:
>> @@ -1042,7 +1060,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode,
>> struct dentry *parent,
>> struct debugfs_blob_wrapper *blob)
>> {
>> - return debugfs_create_file_unsafe(name, mode & 0444, parent, blob, &fops_blob);
>> + return debugfs_create_file_unsafe(name, mode, parent, blob, &fops_blob);
>> }
>
> The minimalist change here would be to s/0444/0666/
>
> That would just allow callers to ask for writeable files without letting them
> add execute permission, or exotic modes like setuid etc.
>
Noted. Thanks for the clarification. Will change to something like below:
return debugfs_create_file_unsafe(name, mode & 0666, parent, blob, &fops_blob);
> -Tony
--
Thanks,
Avadhut Naik
