[viro-vfs:work.dcache2 2/22] fs/coda/cache.c:98:53: error: passing argument 1 of 'd_inode_rcu' from incompatible pointer type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.dcache2
head:   d6e9e3fbf9baed56f046760296fffe6f9dea1bcb
commit: 17ac2dcad930b2f53cb01177421ec1b3a7521082 [2/22] coda_flag_children(): cope with dentries turning negative
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20231108/202311082157.0gY3N2wh-lkp@xxxxxxxxx/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311082157.0gY3N2wh-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311082157.0gY3N2wh-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   fs/coda/cache.c: In function 'coda_flag_children':
>> fs/coda/cache.c:98:53: error: passing argument 1 of 'd_inode_rcu' from incompatible pointer type [-Werror=incompatible-pointer-types]
      98 |                 struct inode *inode = d_inode_rcu(de->d_inode);
         |                                                   ~~^~~~~~~~~
         |                                                     |
         |                                                     struct inode *
   In file included from include/linux/fs.h:8,
                    from fs/coda/cache.c:14:
   include/linux/dcache.h:526:62: note: expected 'const struct dentry *' but argument is of type 'struct inode *'
     526 | static inline struct inode *d_inode_rcu(const struct dentry *dentry)
         |                                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~
   cc1: some warnings being treated as errors


vim +/d_inode_rcu +98 fs/coda/cache.c

    89	
    90	/* this won't do any harm: just flag all children */
    91	static void coda_flag_children(struct dentry *parent, int flag)
    92	{
    93		struct dentry *de;
    94	
    95		rcu_read_lock();
    96		spin_lock(&parent->d_lock);
    97		list_for_each_entry(de, &parent->d_subdirs, d_child) {
  > 98			struct inode *inode = d_inode_rcu(de->d_inode);
    99			/* don't know what to do with negative dentries */
   100			if (inode)
   101				coda_flag_inode(inode, flag);
   102		}
   103		spin_unlock(&parent->d_lock);
   104		rcu_read_unlock();
   105		return; 
   106	}
   107	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux