On Fri, Nov 03, 2023 at 05:49:17PM +0100, Christian Brauner wrote: > > > > Is there a good reason to not just refcount the freezes in general? > > > > > > If we start counting freezes in general we break userspace as > > > freeze_super() is called from ioctl_fsfreeze() and that expects to > > > return EBUSY on an already frozen filesystem. xfs scrub might be another > > > user that might break if we change that. > > > > I guess Christoph meant that we'd count all the sb freezes into the > > refcount (what is now bdev_count) but without HOLDER_BDEV flag we will > > Ah, sorry I didn't get that from the message. That's also not what I meant :) Jan's suggestion makes a little more sense than mine, which I think would have been a good idea when we started from scratch, but does indeed feel dangerous now.
