On Fri, Oct 27, 2023 at 9:03 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Mon, Oct 23, 2023 at 09:07:59PM +0300, Amir Goldstein wrote: > > export_operations ->encode_fh() no longer has a default implementation to > > encode FILEID_INO32_GEN* file handles. > > This statement reads like a factual statement about the current tree. > I'd suggest rewording it to make clear that you are changing the > behavior so that the defaul goes away, and I'd also suggest to move > it after the next paragraph. Ok. will send v3 with those changes. Thanks, Amir.