On Thu, Oct 26, 2023 at 10:44:27AM +0200, Christian Brauner wrote:
> */
> int bdev_freeze(struct block_device *bdev)
> {
> int error = 0;
>
> mutex_lock(&bdev->bd_fsfreeze_mutex);
>
> + if (atomic_inc_return(&bdev->bd_fsfreeze_count) > 1) {
> + mutex_unlock(&bdev->bd_fsfreeze_mutex);
> + return 0;
Use a goto out_unlock here to share the lock release with the
main flow?
> /*
> + * If the superblock wasn't already SB_DYING then we hold
> + * s_umount and can safely drop our temporary reference.
> + */
Spaces instead of tabs here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
