On Fri, Oct 27, 2023 at 9:01 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Thu, Oct 26, 2023 at 10:46:06PM +0300, Amir Goldstein wrote: > > I would much rather turn EXPORTFS into a bool config > > and avoid the unneeded build test matrix. > > Yes. Especially given that the defaul on open by handle syscalls > require it anyway. Note that those syscalls depend on CONFIG_FHANDLE and the latter selects EXPORTFS. Nevertheless, the EXPORTFS=m config seems useless. I will send a patch to change it. The bigger issue is that so many of the filesystems that use the generic export ops do not select EXPORTFS, so it's easier to leave the generic helper in libfs.c as Arnd suggested. Thanks, Amir.