On 10/25/23 8:18 PM, Al Viro wrote: > [in viro/vfs.git#fixes at the moment] > ->ki_pos value is unreliable in such cases. For an obvious example, > consider O_DSYNC write - we feed the data to page cache and start IO, > then we make sure it's completed. Update of ->ki_pos is dealt with > by the first part; failure in the second ends up with negative value > returned _and_ ->ki_pos left advanced as if sync had been successful. > In the same situation write(2) does not advance the file position > at all. Looks good, thanks Al: Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> or let me know if you want me to pick it up. -- Jens Axboe
