Good. Sorry for not doing more (and more serious) reviews, not enough time right now. > #define _dout(fmt, args...) \ > pr_debug(" %12.12s:%-4d : " fmt "%s", \ > ceph_file_part(__FILE__, sizeof(__FILE__)), \ > __LINE__, args); That seems like a wasteful way to do this -- i bet you could shrink binary size with debugging on considerably if you move the file_part into a function. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html