Hi!
> > int invalid_socketfd = 400; /* anything that is not an open file */
> > -int devnull_fd;
> > int socket_fd;
> > int udp_fd;
> >
> > @@ -45,10 +44,6 @@ static struct test_case {
> > (struct sockaddr *)&fsin1, sizeof(fsin1), EBADF,
> > "bad file descriptor"
> > },
> > - {
> > - PF_INET, SOCK_STREAM, 0, &devnull_fd, (struct sockaddr *)&fsin1,
> > - sizeof(fsin1), ENOTSOCK, "fd is not socket"
> > - },
> > {
> > PF_INET, SOCK_STREAM, 0, &socket_fd, (struct sockaddr *)3,
> > sizeof(fsin1), EINVAL, "invalid socket buffer"
> > @@ -73,8 +68,6 @@ static void test_setup(void)
> > sin0.sin_port = 0;
> > sin0.sin_addr.s_addr = INADDR_ANY;
> >
> > - devnull_fd = SAFE_OPEN("/dev/null", O_WRONLY);
> > -
> > socket_fd = SAFE_SOCKET(PF_INET, SOCK_STREAM, 0);
> > SAFE_BIND(socket_fd, (struct sockaddr *)&sin0, sizeof(sin0));
> >
> > @@ -88,7 +81,6 @@ static void test_setup(void)
> >
> > static void test_cleanup(void)
> > {
> > - SAFE_CLOSE(devnull_fd);
> > SAFE_CLOSE(socket_fd);
> > SAFE_CLOSE(udp_fd);
> > }
>
> Is this supposed to be part of the patchset?
>
> I don't mind, but if we are strict, it should be in another commit.
That removes ENOTSOCK test that is now handled in accept03, I suppose I
should have explained that better in the comit message.
--
Cyril Hrubis
chrubis@xxxxxxx
