On Thu, 16 Jul 2009, Andi Kleen wrote: > Sage Weil <sage@xxxxxxxxxxxx> writes: > > + > > +/* > > + * Max file size is a policy choice; in reality we are limited > > + * by 2^64. > > + */ > > +#define CEPH_FILE_MAX_SIZE (1ULL << 40) /* 1 TB */ > > Seems odd to hardcode this here. It is. It's just an arbitrary value to bound recovery time... I'll switch it a server-specified value. > The way attribute packed is used in these files seems rather > random and adhoc, sometimes it is, sometimes it isn't. Not intentionally, it looks like it was missing on some structs that were already naturally aligned. I'll add it everywhere. > I assume you tested that 32bit and 64bit interoperability? Yes. > Is the file system supposed to be endian safe on the wire? Yes, although I don't have access to any big endian machines, so it hasn't been tested. We've been periodically running the code through sparse, though. Thanks! sage -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
