Re: [PATCH v3 00/14] Pass data temperature information to SCSI disk devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/23 12:09, Jens Axboe wrote:
I'm also really against growing struct bio just for this. Why is patch 2
not just using the ioprio field at least?

Hi Jens,

Can you please clarify whether your concern is about the size of struct bio only or also about the runtime impact of the comparisons that have been added in attempt_merge() and blk_rq_merge_ok()? It may be possible to eliminate the overhead of the new comparisons as follows:
* Introduce a union of struct { I/O priority; data lifetime; } and u32.
* Use that union in struct bio instead of bi_ioprio and bi_lifetime.
* Use that union in struct request instead of the ioprio and lifetime
  members.
* In attempt_merge() and blk_rq_merge_ok(), compare the u32 union member
  instead of comparing the I/O priority and data lifetime separately.

Thanks,

Bart.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux