On Tue, 14 Jul 2009, Wu Fengguang wrote: > Here set_page_dirty() can be moved into the page lock. Indeed it can, but you've forgotten to mention why you think that would be a good thing? All I can see is that it would very very slightly increase the page's lock hold time, which wouldn't be an improvement: what improvement are you making? Hugh > > CC: Hugh Dickins <hugh@xxxxxxxxxxx> > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux.orig/mm/shmem.c > +++ linux/mm/shmem.c > @@ -1630,8 +1630,8 @@ shmem_write_end(struct file *file, struc > if (pos + copied > inode->i_size) > i_size_write(inode, pos + copied); > > - unlock_page(page); > set_page_dirty(page); > + unlock_page(page); > page_cache_release(page); > > return copied; -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
