On Tue, Oct 10, 2023 at 10:57:02AM +0100, Joey Gouly wrote: > On Thu, Oct 05, 2023 at 03:34:29PM +0100, Mark Brown wrote: > > On Wed, Sep 27, 2023 at 03:01:18PM +0100, Joey Gouly wrote: > > > Add PKEY support to signals, by saving and restoring POR_EL0 from the stackframe. > > It'd be nice to have at least a basic test that validates that we > > generate a POE signal frame when expected, though that should be a very > > minor thing which is unlikely to ever actually spot anything. > The selftests/mm/protection_keys.c looks for the POE signal frame, do you think > we need a separate test? Like I say it'd be a very minor thing to have one - it is more just a thing you'd go looking for in the signals tests rather than something that's absolutely essential. For trivial things like TPIDR2 I've just added a trivial thing that verifies that the frame is present iff the matching HWCAP is set. Having the test in the mm tests is probably fine though.
Attachment:
signature.asc
Description: PGP signature
