On Mon, Oct 09, 2023 at 06:04:47PM +0200, Vlastimil Babka wrote: > On 10/8/23 22:23, Lorenzo Stoakes wrote: > > Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely > > new regions of virtual memory. > > > > We can share the logic between these invocations and make it absolutely > > explici to reduce confusion around the rather inscrutible parameters > > explicit ... inscrutable > Ack will fix up in v2. > > possessed by vma_merge(). > > > > This also paves the way for a simplification of the core vma_merge() > > implementation, as we seek to make the function entirely an implementation > > detail. > > > > Note that on mmap_region(), vma fields are initialised to zero, so we can > > simply reference these rather than explicitly specifying NULL. > > Right, if they were different from NULL, the code would be broken already. > > > Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx> > > Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx> > Thanks!
