On Mon, Oct 02, 2023 at 06:45:24PM +0200, Jan Kara wrote: > > "Filesystems opening a block device must pass the super_block object > > and fs_holder_ops as the @holder and @hops parameters." > > > > Though TBH I see a surprising amount of fs code that doesn't do this, so > > perhaps it's not so mandatory? > > This is actually a good point. For the main device, fs/super.c takes care > of this (perhaps except for btrfs). So this patch set should not regress > anything. But for other devices such as the journal device or similar, > passing proper holder and holder_ops from the filesystem is necessary. It is is necessary to gain functionality where we call into the fs based on the block device. In the old get_super based world these never worked either as get_super was based on sb->s_dev only.