On Wed, 4 Oct 2023 at 12:04, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > Adding one to after ftrace_release_mod() - where we have that > async_synchronize_full() - would make module unloading match the > loading error path. > > But the synchronize_rcu calls do seem to be a bit randomly sprinkled > about. Maybe the one in free_module() is already sufficient for nls? Never mind. You want it before the ->exit(). That makes sense, and there is no matching code path for the module load failure case (since that implies no - or failed - init()). Linus