Re: [PATCH 07/13] sd: Translate data lifetime information

Bart Van Assche <bvanassche@xxxxxxx> · Tue, 3 Oct 2023 09:58:29 -0700

On 10/2/23 22:48, Avri Altman wrote:
On 10/2/23 06:11, Avri Altman wrote:
sd_setup_read_write_cmnd(struct scsi_cmnd *cmd)
                  ret = sd_setup_rw16_cmnd(cmd, write, lba, nr_blocks,
                                           protect | fua, dld);
          } else if ((nr_blocks > 0xff) || (lba > 0x1fffff) ||
-                  sdp->use_10_for_rw || protect) {
+                  sdp->use_10_for_rw || protect ||
+                  rq->write_hint != WRITE_LIFE_NOT_SET) {

Is this a typo?

I don't see a typo? Am I perhaps overlooking something?
>
Forcing READ(6) into READ(10) because that req carries a write-hint,
Deserves an extra line in the commit log IMO.

Right, I should explain that the READ(6) command does not support write 
hints and hence that READ(10) is selected if a write hint is present.

Thanks,

Bart.