On Mon, 2 Oct 2023 at 08:44, David Sterba <dsterba@xxxxxxx> wrote: > > On Mon, Oct 02, 2023 at 01:28:58PM +0200, David Sterba wrote: > > On Sat, Sep 30, 2023 at 02:00:09AM -0300, Wedson Almeida Filho wrote: > > > From: Wedson Almeida Filho <walmeida@xxxxxxxxxxxxx> > > > > > > This makes it harder for accidental or malicious changes to > > > btrfs_xattr_handlers at runtime. > > > > > > Cc: Chris Mason <clm@xxxxxx> > > > Cc: Josef Bacik <josef@xxxxxxxxxxxxxx> > > > Cc: David Sterba <dsterba@xxxxxxxx> > > > Cc: linux-btrfs@xxxxxxxxxxxxxxx > > > Signed-off-by: Wedson Almeida Filho <walmeida@xxxxxxxxxxxxx> > > > > With slightly updated changelog added to misc-next, thanks. > > Removed again. I did not notice first that this is part of a larger > series, please also CC the [PATCH 0/N] patch. Sorry for the confusion, I will CC you there too. > There's a warning: > > fs/btrfs/super.c: In function ‘btrfs_fill_super’: > fs/btrfs/super.c:1107:21: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > 1107 | sb->s_xattr = btrfs_xattr_handlers; > | ^ > > but the patch changing the type is present in the series. > > Please update the changelog of btrfs patch with: > > Add const specifier also to the pointed array members of > btrfs_xattr_handlers. This moves the whole structure to the .rodata > section which makes it harder for accidental or malicious changes to > btrfs_xattr_handlers at runtime. Will do. Thanks! > or use it for others patches too.
