On Mon, 02 Oct 2023 20:57:04 -0500, Reuben Hawkins wrote: > Readahead was factored to call generic_fadvise. That refactor added an > S_ISREG restriction which broke readahead on block devices. > > In addition to S_ISREG, this change checks S_ISBLK to fix block device > readahead. There is no change in behavior with any file type besides block > devices in this change. > > [...] On vacation so just picking up smaller (hopefully obvious) stuff. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] vfs: fix readahead(2) on block devices https://git.kernel.org/vfs/vfs/c/165bb7140aa4