Re: [PATCH 06/13] scsi_proto: Add struct io_group_descriptor

[Bart Van Assche <bvanassche@xxxxxxx>]

On 10/2/23 04:41, Avri Altman wrote:
> > +/* SBC-5 IO advice hints group descriptor */
> > +struct scsi_io_group_descriptor {
> > +#if defined(__BIG_ENDIAN)
> > +       u8 io_advice_hints_mode: 2;
> > +       u8 reserved1: 3;
> > +       u8 st_enble: 1;
> > +       u8 cs_enble: 1;
> > +       u8 ic_enable: 1;
> > +#elif defined(__LITTLE_ENDIAN)
> > +       u8 ic_enable: 1;
> > +       u8 cs_enble: 1;
> > +       u8 st_enble: 1;
> > +       u8 reserved1: 3;
> > +       u8 io_advice_hints_mode: 2;
> > +#else
> > +#error
> > +#endif
>
> Anything pass byte offset 0 is irrelevant for constrained streams.
> Why do we need that further drill down of the descriptor structure?

The data structures in header file include/scsi/scsi_proto.h follow the
SCSI standards closely. These data structures should not be tailored to
the current use case of these data structures.

Thanks,

Bart.