Hi Xiaobing, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/sched/core] [also build test WARNING on linus/master v6.6-rc3 next-20230928] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Xiaobing-Li/SCHEDULER-Add-an-interface-for-counting-real-utilization/20230928-103219 base: tip/sched/core patch link: https://lore.kernel.org/r/20230928022228.15770-2-xiaobing.li%40samsung.com patch subject: [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization. config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230928/202309281554.CwGBQGhe-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230928/202309281554.CwGBQGhe-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309281554.CwGBQGhe-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from kernel/sched/build_policy.c:52: >> kernel/sched/cputime.c:482:6: warning: no previous prototype for 'get_sqthread_util' [-Wmissing-prototypes] 482 | void get_sqthread_util(struct task_struct *p) | ^~~~~~~~~~~~~~~~~ kernel/sched/cputime.c: In function 'get_sqthread_util': kernel/sched/cputime.c:484:56: error: 'struct kernel_cpustat' has no member named 'sq_util' 484 | struct task_struct **sqstat = kcpustat_this_cpu->sq_util; | ^~ kernel/sched/cputime.c:486:29: error: 'MAX_SQ_NUM' undeclared (first use in this function) 486 | for (int i = 0; i < MAX_SQ_NUM; i++) { | ^~~~~~~~~~ kernel/sched/cputime.c:486:29: note: each undeclared identifier is reported only once for each function it appears in kernel/sched/cputime.c:495:31: error: 'struct kernel_cpustat' has no member named 'flag' 495 | if (!kcpustat_this_cpu->flag) { | ^~ kernel/sched/cputime.c:497:42: error: 'struct kernel_cpustat' has no member named 'sq_util' 497 | kcpustat_this_cpu->sq_util[j] = NULL; | ^~ kernel/sched/cputime.c:498:34: error: 'struct kernel_cpustat' has no member named 'flag' 498 | kcpustat_this_cpu->flag = true; | ^~ vim +/get_sqthread_util +482 kernel/sched/cputime.c 481 > 482 void get_sqthread_util(struct task_struct *p) 483 { 484 struct task_struct **sqstat = kcpustat_this_cpu->sq_util; 485 486 for (int i = 0; i < MAX_SQ_NUM; i++) { 487 if (sqstat[i] && (task_cpu(sqstat[i]) != task_cpu(p) 488 || sqstat[i]->__state == TASK_DEAD)) 489 sqstat[i] = NULL; 490 } 491 492 if (strncmp(p->comm, "iou-sqp", 7)) 493 return; 494 495 if (!kcpustat_this_cpu->flag) { 496 for (int j = 0; j < MAX_SQ_NUM; j++) 497 kcpustat_this_cpu->sq_util[j] = NULL; 498 kcpustat_this_cpu->flag = true; 499 } 500 int index = MAX_SQ_NUM; 501 bool flag = true; 502 503 for (int i = 0; i < MAX_SQ_NUM; i++) { 504 if (sqstat[i] == p) 505 flag = false; 506 if (!sqstat[i] || task_cpu(sqstat[i]) != task_cpu(p)) { 507 sqstat[i] = NULL; 508 if (i < index) 509 index = i; 510 } 511 } 512 if (flag && index < MAX_SQ_NUM) 513 sqstat[index] = p; 514 } 515 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
