> What you are saying makes sense. > And if we are being honest, I think that the right thing to do from the > beginning was to separate the bug fix commit from the UAPI change. > > The minimal bug fix is S_ISREG || S_ISBLK, which > mentions the Fixes commit and will be picked for stable kernels. > > Following up with another one or two patches that change > the behavior of posix_fadvise on socket and readahead on > socket and pipe. > > The UAPI change is not something that has to go to stable > and it should be easily revertable independently of the bug fix. > Doing it otherwise would make our lives much harder if regressions > turn up from the UAPI change. > > Christian, Matthew, > > Do you agree? Fine by me.