On Mon, Jul 06, 2009 at 09:24:46PM +0200, Andi Kleen wrote: > > Some benchmark testing shows touch_atime to be high up in profile > logs for IO intensive workloads. Most likely that's due to the lock > in mnt_want_write(). Unfortunately touch_atime first takes the lock, > and then does all the other tests that could avoid atime updates (like > noatime or relatime). > > Do it the other way round -- first try to avoid the update and only > then if that didn't succeed take the lock. That works because none of > the atime avoidance tests rely on locking. > > This also eliminates a goto. > > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> Looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
