On Thu, Sep 21, 2023 at 07:27:08AM -0700, Bart Van Assche wrote: > On 9/21/23 00:46, Niklas Cassel wrote: > > Considering that this API (F_GET_FILE_RW_HINT / F_SET_FILE_RW_HINT) was > > previously only used by NVMe (NVMe streams). > > That doesn't sound correct to me. I think support for this API was added > in F2FS in November 2017 (commit 4f0a03d34dd4 ("f2fs: apply write hints > to select the type of segments for buffered write")). That was a few > months after NVMe stream support was added (June 2017) by commit > f5d118406247 ("nvme: add support for streams and directives"). > > > Should NVMe streams be brought back? Yes? No? > > From commit 561593a048d7 ("Merge tag 'for-5.18/write-streams-2022-03-18' > of git://git.kernel.dk/linux-block"): "This removes the write streams > support in NVMe. No vendor ever really shipped working support for this, > and they are not interested in supporting it." It sounds like UFS is at the same stage that NVMe got to -- standard exists, no vendor has committed to actually shipping it. Isn't bringing it back a little premature?