Re: [PATCH 1/2] fs/fuse: Rename DIRECT_IO_RELAX to DIRECT_IO_ALLOW_MMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/20/23 10:31, Hanna Czenczek wrote:
On 20.09.23 04:40, Tyler Fanelli wrote:
- *                       allow shared mmap
+ * FUSE_DIRECT_IO_ALLOW_MMAP: allow shared mmap in FOPEN_DIRECT_IO mode.
   */
  #define FUSE_ASYNC_READ        (1 << 0)
  #define FUSE_POSIX_LOCKS    (1 << 1)
@@ -449,7 +448,7 @@ struct fuse_file_lock {
  #define FUSE_HAS_INODE_DAX    (1ULL << 33)
  #define FUSE_CREATE_SUPP_GROUP    (1ULL << 34)
  #define FUSE_HAS_EXPIRE_ONLY    (1ULL << 35)
-#define FUSE_DIRECT_IO_RELAX    (1ULL << 36)
+#define FUSE_DIRECT_IO_ALLOW_MMAP (1ULL << 36)

Is it allowed to remove FUSE_DIRECT_IO_RELAX now that it was already present in a uapi header?

Personally, I don’t mind keeping the name for the flag and just change the documentation.  Or we might keep the old name as an alias for the new one.

It is only in linux-6.6-rcX, not in any released version. Which is why Miklos posted that he is going to send these patches as -rc update and not only in 6.7.

Thanks,
Bernd



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux