On 9/18/23 16:00, Matthew Wilcox wrote:
On Mon, Sep 18, 2023 at 01:05:01PM +0200, Hannes Reinecke wrote:
Use the correct mapping order in grow_dev_page() to ensure folios
are created with the correct order.
I see why you did this, but I think it's fragile. __filemap_get_folio()
will happily decrease 'order' if memory allocation fails. I think
__filemap_get_folio() needs to become aware of the minimum folio
order for this mapping, and then we don't need this patch.
Overall, I like bits of this patchset and I like bits of Pankaj's ;-)
To be expected. It's basically parallel development, me and Pankaj
working independently and arriving at different patchsets.
Will see next week at ALPSS if we can merge them into something sensible.
And 'grow_dev_page()' was really done by audit, and I'm not sure if my
tests even exercised this particular codepath. So yeah, I'm with you.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
