Jens Axboe wrote:
+static struct bdi_work *bdi_alloc_work(struct super_block *sb, long nr_pages,
+ enum writeback_sync_modes sync_mode)
+{
+ struct bdi_work *work;
+
+ work = kmalloc(sizeof(*work), GFP_ATOMIC);
+ if (work)
+ bdi_work_init(work, sb, nr_pages, sync_mode);
- wb_start_writeback(&bdi->wb, sb, nr_pages, sync_mode);
+ return work;
+}
Since the caller of this function handles kmalloc failure gracefully,
should we also pass __GFP_NOWARN flag to kmalloc() here, in order to
avoid large and scary no-memory complaints?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
