On Fri, Sep 15, 2023 at 02:32:51PM -0700, Luis Chamberlain wrote: > +/* XXX: shift 20 (1 MiB LBA) crashes on pure-iomap */ > +#define NVME_MAX_SHIFT_SUPPORTED 19 I imagine somewhere we do a PAGE_SIZE << 20 and it overflows an int to 0. I've been trying to use size_t everywhere, but we probably missed something. Does 19 work on a machine with 64kB pages? My guess is no.