On 12/09/2023 06:27, Anand Jain wrote:
>
> We may need to fix the command 'btrfs filesystem show' aswell.
> Could you test having more than one single-devices with
> the same fsid and running 'btrfs filesystem show' to ensure
> it can still display all the devices?
>
> Thx.
> Anand
>
Hi Anand, thanks for noticing that. I've made this test (with the
patches V4), the result:
$ lsblk | grep nvme
nvme0n1 259:0 0 1G 0 disk
└─nvme0n1p1 259:1 0 1022M 0 part /mnt
nvme1n1 259:2 0 1G 0 disk
└─nvme1n1p1 259:3 0 1022M 0 part /mnt2
$ dmesg | grep TEMP
[ 802.818873] BTRFS info: random fsid
(c80a52e3-8f16-4095-bdc2-cc24bd01cf7d) set for TEMP_FSID device
/dev/nvme0n1p1 (real fsid 94b67f81-b51f-479e-9f44-0d33d5cec2d4)
[ 805.761222] BTRFS info: random fsid
(5a0a6628-8cd0-4353-8daf-b01ca254c10d) set for TEMP_FSID device
/dev/nvme1n1p1 (real fsid 94b67f81-b51f-479e-9f44-0d33d5cec2d4)
$ btrfs filesystem show
Label: none uuid: c80a52e3-8f16-4095-bdc2-cc24bd01cf7d
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme0n1p1
Label: none uuid: 5a0a6628-8cd0-4353-8daf-b01ca254c10d
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme1n1p1
Label: none uuid: 94b67f81-b51f-479e-9f44-0d33d5cec2d4
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme1n1p1
It seems to me it's correct "enough" right? It shows the mounted
filesystems according to the temporary fsid.
Also, I've noticed that the real fsid is omitted for device nvme0n1p1,
i.e., the command de-duplicates devices with the same fsid - tested here
without the TEMP_FSID feature and it behaves the same way.
In case you think we could improve such output, I appreciate
suggestions, and I'd be glad if that could be considered an improvement
(i.e., not blocking the patch merge on misc-next) since I might not have
the time to work on this for some weeks...
Cheers,
Guilherme
