Hi Krister, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.6-rc1 next-20230911] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Krister-Johansen/fuse-revalidate-move-lookup-into-a-separate-function/20230912-051352 base: linus/master patch link: https://lore.kernel.org/r/9a2b0c5b625cd88c561289bf7d4d7dfe305c10ed.1693440240.git.kjlx%40templeofstupid.com patch subject: [PATCH 1/2] fuse: revalidate: move lookup into a separate function config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230912/202309120853.QbAMM1to-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120853.QbAMM1to-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309120853.QbAMM1to-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): fs/fuse/dir.c: In function 'fuse_dentry_revalidate_lookup': >> fs/fuse/dir.c:194:28: warning: variable 'fi' set but not used [-Wunused-but-set-variable] 194 | struct fuse_inode *fi; | ^~ vim +/fi +194 fs/fuse/dir.c 185 186 static int fuse_dentry_revalidate_lookup(struct fuse_mount *fm, 187 struct dentry *entry, 188 struct inode *inode, 189 struct fuse_entry_out *outarg, 190 bool *lookedup) 191 { 192 struct dentry *parent; 193 struct fuse_forget_link *forget; > 194 struct fuse_inode *fi; 195 FUSE_ARGS(args); 196 int ret; 197 198 forget = fuse_alloc_forget(); 199 ret = -ENOMEM; 200 if (!forget) 201 goto out; 202 203 parent = dget_parent(entry); 204 fuse_lookup_init(fm->fc, &args, get_node_id(d_inode(parent)), 205 &entry->d_name, outarg); 206 ret = fuse_simple_request(fm, &args); 207 dput(parent); 208 209 /* Zero nodeid is same as -ENOENT */ 210 if (!ret && !outarg->nodeid) 211 ret = -ENOENT; 212 if (!ret) { 213 fi = get_fuse_inode(inode); 214 if (outarg->nodeid != get_node_id(inode) || 215 (bool) IS_AUTOMOUNT(inode) != (bool) (outarg->attr.flags & FUSE_ATTR_SUBMOUNT)) { 216 fuse_queue_forget(fm->fc, forget, 217 outarg->nodeid, 1); 218 goto invalid; 219 } 220 *lookedup = true; 221 } 222 kfree(forget); 223 if (ret == -ENOMEM || ret == -EINTR) 224 goto out; 225 if (ret || fuse_invalid_attr(&outarg->attr) || 226 fuse_stale_inode(inode, outarg->generation, &outarg->attr)) { 227 goto invalid; 228 } 229 230 ret = 1; 231 out: 232 return ret; 233 234 invalid: 235 ret = 0; 236 goto out; 237 } 238 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
