On Thu, Sep 07, 2023 at 08:23:09AM -0700, Guenter Roeck wrote: > On 9/7/23 06:54, Christian Brauner wrote: > > On Thu, Sep 07, 2023 at 06:05:40AM -0700, Guenter Roeck wrote: > > > On Wed, Aug 09, 2023 at 03:05:45PM -0700, Christoph Hellwig wrote: > > > > As a rule of thumb everything allocated to the fs_context and moved into > > > > the super_block should be freed by ->kill_sb so that the teardown > > > > handling doesn't need to be duplicated between the fill_super error > > > > path and put_super. Implement an ntfs3-specific kill_sb method to do > > > > that. > > > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx> > > > > > > This patch results in: > > > > The appended patch should fix this. Are you able to test it? > > I will as well. > > Yes, this patch restores the previous behavior (no more backtrace or crash). Great, I'll get this fixed in upstream. > > Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > I say "restore previous behavior" because my simple "recursive copy; partially > remove copied files" test still fails. That problem apparently existed since > ntfs3 has been introduced (I see it as far back as v5.15). I don't think anyone finds that surprising.
