Hi Alan, > What about all the other damage vendors do to the tree and the junk they > stuff in their kernels - we don't accept that upstream either ? sure, but there is no need to encourage bad behaviour by building it into the upstream :-) > Its manual unless the device is visibly corrupted but it should still > work. ok, with the patch I've posted applied, can you reproduce this? Perhaps by deliberately corrupting the device in some other way (using dd?) then running a chkdsk? If you try to reproduce it then make sure you completely fill the VFAT directory. If you have (for example) only 1000 files in a directory then you'd have to redo the deliberate corruption test with new files about 2000 times before you get a single error and rename from chkdsk. If you only have 100 files then you'll have to do it nearly a million times per rename. > The point I was making is that the world of "Windows PC & Linux > handheld device" is an important one. yes, it's an extremely important use for Linux. That is why I've spent the last 4 months working on ensuring that it continues to be viable, by trying to create the most legally robust, most compatible patch I can that allows these devices to continue to exist without running significant legal risks. If there is another approach that achieves this goal in a better way then we should look at it. Can you suggest an alternative that will work better for Linux handheld device makers? Cheers, Tridge -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html