On Tue, Sep 05, 2023 at 08:39:53AM -0700, Darrick J. Wong wrote: > On Tue, Sep 05, 2023 at 02:41:20PM +0200, Christoph Hellwig wrote: > > iomap_to_bh currently BUG()s when the passed in block number is not > > in the iomap. For file systems that have proper synchronization this > > should never happen and so far hasn't in mainline, but for block devices > > size changes aren't fully synchronized against ongoing I/O. Instead > > of BUG()ing in this case, return -EIO to the caller, which already has > > proper error handling. While we're at it, also return -EIO for an > > unknown iomap state instead of returning garbage. > > > > Fixes: 487c607df790 ("block: use iomap for writes to block devices") > > Reported-by: syzbot+4a08ffdf3667b36650a1@xxxxxxxxxxxxxxxxxxxxxxxxx > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > Looks like a good improvement. Who should this go through, me (iomap) > or viro/brauner (vfs*) ? > > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > (lol is email down again?) I can grab it if you want. What's up with email? Did you send this a long time ago?