On Mon, Aug 28, 2023 at 05:00:36AM -0700, Christoph Hellwig wrote: > On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote: > > use helpers for calling f_op->{read,write}_iter() in read_write.c > > > > Why? We really should just remove the completely pointless wrappers > instead. Especially because it means you chase this helper to figure out what's actually going on. If there was more to it then it would make sense but not just as a pointless wrapper.