Re: [PATCH v5 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Juergen,

On 2023/8/24 14:00, Juergen Gross wrote:
On 24.08.23 05:42, Qi Zheng wrote:
Use new APIs to dynamically allocate the xen-backend shrinker.

Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
CC: Juergen Gross <jgross@xxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
CC: xen-devel@xxxxxxxxxxxxxxxxxxxx

Acked-by: Juergen Gross <jgross@xxxxxxxx>

Thanks for your review!


Just one note: it seems as if most users will set seeks to DEFAULT_SEEKS.
Wouldn't it be better to do this in shrinker_alloc() and let only callers
who want a different value overwrite that?

I think it makes sense, will do.

Thanks,
Qi



Juergen



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux