On Mon, 21 Aug 2023 10:39:20 -0700, Hugh Dickins wrote: > It is particularly important for the userns mount case (when a sensible > nr_inodes maximum may not be enforced) that tmpfs user xattrs be subject > to memory cgroup limiting. Leave temporary buffer allocations as is, > but change the persistent simple xattr allocations from GFP_KERNEL to > GFP_KERNEL_ACCOUNT. This limits kernfs's cgroupfs too, but that's good. > > (I had intended to send this change earlier, but had been confused by > shmem_alloc_inode() using GFP_KERNEL, and thought a discussion would be > needed to change that too: no, I was forgetting the SLAB_ACCOUNT on that > kmem_cache, which implicitly adds __GFP_ACCOUNT to all its allocations.) > > [...] Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [1/1] tmpfs,xattr: GFP_KERNEL_ACCOUNT for simple xattrs https://git.kernel.org/vfs/vfs/c/572a3d1e5d3a