Hi Gabriel, kernel test robot noticed the following build warnings: [auto build test WARNING on tytso-ext4/dev] [also build test WARNING on linus/master] [cannot apply to tyhicks-ecryptfs/next ericvh-v9fs/for-next viro-vfs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/fs-Expose-helper-to-check-if-a-directory-needs-casefolding/20230812-084506 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev patch link: https://lore.kernel.org/r/20230812004146.30980-5-krisman%40suse.de patch subject: [PATCH v5 04/10] fs: Expose name under lookup to d_revalidate hooks config: x86_64-randconfig-x012-20230817 (https://download.01.org/0day-ci/archive/20230817/202308171740.0u9DuWtr-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171740.0u9DuWtr-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202308171740.0u9DuWtr-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/ecryptfs/dentry.c:33: warning: Function parameter or member 'name' not described in 'ecryptfs_d_revalidate' vim +33 fs/ecryptfs/dentry.c 237fead619984c Michael Halcrow 2006-10-04 17 237fead619984c Michael Halcrow 2006-10-04 18 /** 237fead619984c Michael Halcrow 2006-10-04 19 * ecryptfs_d_revalidate - revalidate an ecryptfs dentry 237fead619984c Michael Halcrow 2006-10-04 20 * @dentry: The ecryptfs dentry 0b728e1911cbe6 Al Viro 2012-06-10 21 * @flags: lookup flags 237fead619984c Michael Halcrow 2006-10-04 22 * 237fead619984c Michael Halcrow 2006-10-04 23 * Called when the VFS needs to revalidate a dentry. This 237fead619984c Michael Halcrow 2006-10-04 24 * is called whenever a name lookup finds a dentry in the 237fead619984c Michael Halcrow 2006-10-04 25 * dcache. Most filesystems leave this as NULL, because all their 237fead619984c Michael Halcrow 2006-10-04 26 * dentries in the dcache are valid. 237fead619984c Michael Halcrow 2006-10-04 27 * 237fead619984c Michael Halcrow 2006-10-04 28 * Returns 1 if valid, 0 otherwise. 237fead619984c Michael Halcrow 2006-10-04 29 * 237fead619984c Michael Halcrow 2006-10-04 30 */ 0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 31 static int ecryptfs_d_revalidate(struct dentry *dentry, 0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 32 const struct qstr *name, unsigned int flags) 237fead619984c Michael Halcrow 2006-10-04 @33 { 2edbfbf1c1ab0a Al Viro 2013-09-15 34 struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry); 5556e7e6d30e8e Tyler Hicks 2015-08-05 35 int rc = 1; 237fead619984c Michael Halcrow 2006-10-04 36 0b728e1911cbe6 Al Viro 2012-06-10 37 if (flags & LOOKUP_RCU) 34286d6662308d Nicholas Piggin 2011-01-07 38 return -ECHILD; 34286d6662308d Nicholas Piggin 2011-01-07 39 5556e7e6d30e8e Tyler Hicks 2015-08-05 40 if (lower_dentry->d_flags & DCACHE_OP_REVALIDATE) 0838ae103beaf6 Gabriel Krisman Bertazi 2023-08-11 41 rc = lower_dentry->d_op->d_revalidate(lower_dentry, name, flags); 5556e7e6d30e8e Tyler Hicks 2015-08-05 42 2b0143b5c986be David Howells 2015-03-17 43 if (d_really_is_positive(dentry)) { 5556e7e6d30e8e Tyler Hicks 2015-08-05 44 struct inode *inode = d_inode(dentry); ae56fb16337c88 Michael Halcrow 2006-11-16 45 5556e7e6d30e8e Tyler Hicks 2015-08-05 46 fsstack_copy_attr_all(inode, ecryptfs_inode_to_lower(inode)); 5556e7e6d30e8e Tyler Hicks 2015-08-05 47 if (!inode->i_nlink) 5556e7e6d30e8e Tyler Hicks 2015-08-05 48 return 0; ae56fb16337c88 Michael Halcrow 2006-11-16 49 } 237fead619984c Michael Halcrow 2006-10-04 50 return rc; 237fead619984c Michael Halcrow 2006-10-04 51 } 237fead619984c Michael Halcrow 2006-10-04 52 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
