[snip]
> +static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter
> *iter)
> +{
> + ssize_t ret;
> + struct file *file = iocb->ki_filp;
> + struct inode *inode = file_inode(file);
> + struct exfat_inode_info *ei = EXFAT_I(inode);
> + loff_t pos = iocb->ki_pos;
> + loff_t valid_size;
> +
> + inode_lock(inode);
> +
> + valid_size = ei->valid_size;
> +
> + ret = generic_write_checks(iocb, iter);
> + if (ret < 0)
> + goto unlock;
> +
> + if (pos > valid_size) {
> + ret = exfat_file_zeroed_range(file, valid_size, pos);
Can we use block_write_begin instead of cont_write_begin in exfat_write_begin?
> + if (ret < 0 && ret != -ENOSPC) {
> + exfat_err(inode->i_sb,
> + "write: fail to zero from %llu to %llu(%ld)",
> + valid_size, pos, ret);
> + }
> + if (ret < 0)
> + goto unlock;
> + }
> +
> + ret = __generic_file_write_iter(iocb, iter);
> + if (ret < 0)
Probably It should be if (ret <= 0)...
> + goto unlock;
> +
> + if (pos + ret > i_size_read(inode))
> + i_size_write(inode, pos + ret);
> +
> + if (pos + ret > ei->valid_size)
> + ei->valid_size = pos + ret;
> +
> + /*
> + * If valid_size is extended with sector-aligned length in
> + * exfat_get_block(), set to the writren length.
> + */
> + if (i_size_read(inode) < ei->valid_size)
> + ei->valid_size = i_size_read(inode);
> +
> + mark_inode_dirty(inode);
> + inode_unlock(inode);
> +
> + if (pos > valid_size && iocb_is_dsync(iocb)) {
> + ssize_t err = vfs_fsync_range(file, valid_size, pos - 1,
> + iocb->ki_flags & IOCB_SYNC);
It should be moved to exfat_file_zeroed_range() ?
Thanks.
