On Sat, Aug 12, 2023 at 07:04:00PM +0200, Heiko Carstens wrote: > On Sat, Aug 12, 2023 at 12:51:33PM +0200, Christoph Hellwig wrote: > > The buildbot pointed out correctly (but rather late), that the special > > s390/dasd export needs a _MODULE postfix, so this will have to be > > folded in: > > > > diff --git a/block/bdev.c b/block/bdev.c > > index 2a035be7f3ee90..a20263fa27a462 100644 > > --- a/block/bdev.c > > +++ b/block/bdev.c > > @@ -967,7 +967,7 @@ void bdev_mark_dead(struct block_device *bdev, bool surprise) > > > > invalidate_bdev(bdev); > > } > > -#ifdef CONFIG_DASD > > +#ifdef CONFIG_DASD_MODULE > > This needs to be > > #if IS_ENABLED(CONFIG_DASD) > > to cover both CONFIG_DASD=y and CONFIG_DASD=m. Sure, but if DASD is built-in, the symbol doesn't need to be exported
