Hi Andreas,
Andreas Dilger wrote:
> On Jun 23, 2009 17:25 +0900, Akira Fujita wrote:
>> Block allocation restriction is cleared with this ioctl or umount filesystem.
>>
>> #define EXT4_IOC_CLR_GLOBAL_ALLOC_RULE _IOW('f', 17, struct ext4_alloc_rule);
>>
>> struct ext4_alloc_rule {
>> __u64 start; /* start physical offset to clear rule */
>> __u64 len; /* number of blocks to be clear */
>> __u32 alloc_flag; /* not used, should be zero */
>> };
>
> Why not call EXT4_IOC_ADD_GLOBAL_ALLOC_RULE with a "clear" flag?
Yes, having "clear" flag makes more sense
than implementing ioctls separately.
I will add "clear" flag (EXT4_MB_CLEAR_ALLOC_RULE) to alloc_flag
and remove EXT4_IOC_CLR_GLOBAL_ALLOC_RULE ioctl in the next version.
Thanks,
Akira Fujita
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
